fix(langchain): correctly initialize huggingface models in init_chat_model #33167
+39
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
eyurtsev
reviewed
Sep 30, 2025
There was a problem hiding this comment.
@aaronseq12 thanks for the contribution -- there seem to be a lot of typos in this PR, do you want to try and resolve?
This was referenced Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change fixes a
ValidationErrorthat occurred when usinginit_chat_modelwithmodel_provider="huggingface".The previous implementation incorrectly passed all keyword arguments directly to the
ChatHuggingFaceconstructor, which expects anllmobject rather than amodel_id. This caused a Pydantic error when arguments liketaskwere provided.The fix updates the logic to first correctly instantiate a
HuggingFacePipelineobject using thefrom_model_idclass method, which properly handles arguments liketask. This initialized pipeline object is then passed to theChatHuggingFacewrapper, resolving the issue.A unit test has been added to verify the fix and prevent regressions.
Closes #28226
Issue:
Fixes #28226
Dependencies:
None